Opened 14 years ago

Closed 13 years ago

#2564 closed Bugs (fixed)

buffer overrun when reported error message is greater than 512

Reported by: m.champlon@… Owned by: Gennadiy Rozental
Milestone: Boost 1.40.0 Component: test
Version: Boost 1.37.0 Severity: Problem
Keywords: buffer overrun vsnprintf Cc:

Description

Hello,

At this location ​https://svn.boost.org/trac/boost/browser/trunk/boost/test/impl/execution_monitor.ipp#L203 Instead of :

BOOST_TEST_VSNPRINTF( buf, sizeof(buf), format, args );

The code should probably look like :

BOOST_TEST_VSNPRINTF( buf, sizeof(buf)-1, format, args ); buf[sizeof(buf)-1] = 0;

Thanks ! MAT.

Change History (4)

comment:1 by Gennadiy Rozental, 14 years ago

Resolution: → fixed
Status: new → closed

comment:2 by anonymous, 14 years ago

The fix has not only skipped 1.38 contrary to what is stated in the 'milestone' field but it also appears not to have been merged to the release branch and might skip 1.39 too.

comment:3 by anonymous, 13 years ago

Resolution: fixed
Status: closed → reopened

Can you please merge this fix into the release branch ?

comment:4 by anonymous, 13 years ago

Milestone: Boost 1.38.0 → Boost 1.40.0
Resolution: → fixed
Status: reopened → closed

It's been merged to the release branch at last, see ​http://svn.boost.org/svn/boost/branches/release/boost/test/impl/execution_monitor.ipp

Note: See TracTickets for help on using tickets.