Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#2594 closed Bugs (fixed)

Bug into all_reduce

Reported by: micdestefano@… Owned by: Douglas Gregor
Milestone: Boost 1.39.0 Component: mpi
Version: Boost Development Trunk Severity: Problem
Keywords: all_reduce, Cc: Matthias Troyer

Description

Good Morning.

I've found a bug into the file

boost/mpi/collectives/all_reduce.hpp

At line 36 you should change

is_mpi_op<Op, T>::op()

into

(is_mpi_op<Op, T>::op())

i.e. add a couple of parentheses around the expression. Without those parentheses, this build error occurs:

error: macro "MPI_Allreduce" passed 7 arguments, but takes just 6

because the comma that separates template parameters confuses the preprocessor.

I've noticed that the bug is still present into the Boost.MPI development version.

My compiler is gcc 4.1.2.

Thank you in advance.
Michele De Stefano

Change History (6)

comment:1 by federico.golfre@…, 14 years ago

Hi!

Using the gather function of the Boost.MPI (which calls the MPI_Allreduce) my compiler (gcc 4.1.2) throws the same error.

I've changed the boost/mpi/collectives/all_reduce.hpp following the instructions posted by Michele and it runs.

Thank you, Federico Golfrè Andreasi

comment:2 by anonymous, 14 years ago

Owner: changed from Douglas Gregor to Matthias Troyer
Summary: Bub into all_reduceBug into all_reduce

Good Morning. I noticed that on January, 31st, Boost 1.38.0 will be released. I've also noticed that the bug I signaled (see above) has not been fixed yet.

May you fix it before the release, please ?

I also suggested the modification and I'm sure that in 5 minutes you'll be done.
Please, control other collectives too.

Thank you again.

Michele

comment:3 by micdestefano@…, 14 years ago

Milestone: Boost 1.38.0Boost 1.39.0
Owner: changed from Matthias Troyer to Douglas Gregor
Version: Boost 1.36.0Boost 1.38.0

I re-opened this ticket, because the bug is still present into the 1.38.0 version.

comment:4 by micdestefano@…, 13 years ago

Version: Boost 1.38.0Boost Development Trunk

The bug is still present into the 1.39 release.

comment:5 by Matthias Troyer, 13 years ago

Resolution: fixed
Status: newclosed

comment:6 by buy Cialis medication, 13 years ago

If I'd known computer science was going to be like this, I'd never have given up being a rock 'n' roll star.

-- G. Hirst

compra il levitra why to order fioricet buy one tab of Cialis /ZB9BhV sleeping tramadol

Note: See TracTickets for help on using tickets.