Opened 18 years ago

Closed 17 years ago

#262 closed Bugs (Wont Fix)

Minor coding issue

Reported by: morban Owned by: az_sw_dude
Milestone: Component: date_time
Version: None Severity:
Keywords: Cc:

Description

The functions:

gregorian_calendar_base<ymd_type_,date_int_type_>::fr
om_day_number(date_int_type dayNumber) 

and:
  
gregorian_calendar_base<ymd_type_,date_int_type_>::fr
om_julian_day_number(date_int_type dayNumber) 

in "gregorian_calander.ipp" share the same code, except 
for the static_cast to year_type (which is  
static_cast<unsigned short> in the first and 
static_cast<year_type> in the second of these 
functions. 

It seems that the one of these functions is redundant 
(and that the first one has a wrong type cast)...


Change History (2)

comment:1 by az_sw_dude, 17 years ago

Logged In: YES 
user_id=579686

Thx for the report.  I agree this code could be cleaned up a
bit.  This code will be rewritten in a future
standardization release (1.35?) and this will be addressed
at that time.  In the meantime, it works fine and doesn't
cause any known issues.

Jeff

comment:2 by az_sw_dude, 17 years ago

Status: assignedclosed
Note: See TracTickets for help on using tickets.