Opened 14 years ago

Closed 14 years ago

#2641 closed Bugs (fixed)

spaces instead of tabs in Makefile; DOS line endings in Unix shell scripts

Reported by: Albert Davidson Chou <HotFusionMan@…> Owned by: Beman Dawes
Milestone: Boost 1.38.0 Component: build
Version: Boost 1.37.0 Severity: Showstopper
Keywords: Cc:

Description

I downloaded the 7-zipped distribution and discovered that many of the files that contain the string /bin/sh or /bin/bash (including the top-level configure script!) used DOS line endings, which made bash on OS X 10.4.11 halt claiming there was no such interpreter.

After I fixed the line endings and went to run make, I discovered that the top-level Makefile had two space characters at the beginnings of lines where there should be a tab character for proper Makefile format!

Change History (5)

comment:1 by Vladimir Prus, 14 years ago

Resolution: invalid
Status: newclosed

The 7-zip package is meant for Windows users and therefore uses Windows line endings. The Makefile in my SVN copy has tab characters, so I suspect you've converted that to space characters while doing your fix.

I suggest you download the tar.bz2 package. In any case, I am not responsible for Makefile.

comment:2 by Albert Davidson Chou <HotFusionMan@…>, 14 years ago

Resolution: invalid
Status: closedreopened

7-zip exists on Unix, too (as my experience today attests), so can you label the .7z file somehow so it indicates it's meant for Windows? Either in the filename or on the download page, just some indication.

comment:3 by Vladimir Prus, 14 years ago

Owner: changed from Vladimir Prus to René Rivera
Status: reopenednew

I don't think SF release system allows to mark a package as Windows-only source, so altering a name is the only option. Rene?

comment:4 by René Rivera, 14 years ago

Owner: changed from René Rivera to Beman Dawes

SF doesn't have options for tagging source code as anything but portable. So the only choice I see is to tag the release packages with an appropriate name that identifies the kind of EOLs in the source:

  • boost_1_38_0_crlf.zip
  • boost_1_38_0_crlf.7z
  • boost_1_38_0_lf.tar.gz
  • boost_1_38_0_lf.tar.bz2

And we may want to consider adding archives for some other common options:

  • boost_1_38_0_lf.7z (for Unix with 7zp)
  • boost_1_38_0_crlf.tar.bz2 (for Cygwin users with CRLF installs)

comment:5 by Daniel James, 14 years ago

Resolution: fixed
Status: newclosed

I'm marking this particular bug as fixed - as it is. There's already bug about documenting the line endings, #2177. #2790 is also relevant.

Note: See TracTickets for help on using tickets.