Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#2767 closed Bugs (fixed)

#pragma warning pop is missing in boost/function/function_base.hpp

Reported by: Denis Gurchenkov <dgurchenkov@…> Owned by: Douglas Gregor
Milestone: Boost 1.39.0 Component: function
Version: Boost 1.38.0 Severity: Problem
Keywords: #pragma warning Cc:

Description

boost/function/function_base.hpp contains #pragma warning push directive but does not contain the corresponding #pragma warning pop.

As a result, global warnings state is changed and thus warnings in user code may not be reported correctly.

#pragma warnings push/pop are Visual C++ specific pragmas that maintain a stack of warnings state. Having push and no pop means stack nesting is broken.

Fix is trivial (patchfile is attached).

Attachments (1)

patchfile.patch​ (338 bytes ) - added by Denis Gurchenkov <dgurchenkov@…> 14 years ago.
suggested fix (diff format)

Download all attachments as: .zip

Change History (3)

by Denis Gurchenkov <dgurchenkov@…>, 14 years ago

Attachment: patchfile.patch​ added

suggested fix (diff format)

comment:1 by Daniel James, 13 years ago

Resolution: → fixed
Status: new → closed

(In [53694]) Add missing #pragma warning(pop). Fixes #2767.

comment:2 by Daniel James, 13 years ago

(In [54410]) Add missing #pragma warning(pop) in Boost.Function.

Merged revisions 53694 via svnmerge from ​https://svn.boost.org/svn/boost/trunk

........

r53694 | danieljames | 2009-06-06 16:31:47 +0100 (Sat, 06 Jun 2009) | 1 line

Add missing #pragma warning(pop). Fixes #2767.

........

Note: See TracTickets for help on using tickets.