Opened 14 years ago

Closed 13 years ago

#2785 closed Patches (fixed)

[patch] GCC Shadow errors in circular buffer

Reported by: dustin@… Owned by: Jan Gaspar
Milestone: Boost 1.40.0 Component: circular_buffer
Version: Boost 1.38.0 Severity: Cosmetic
Keywords: Cc:

Description

Patch for shadow errors in circular buffer library

Attachments (2)

circular_buffer.tar.gz​ (2.8 KB ) - added by dustin@… 14 years ago.
trivial patch for shadow errors
circular_buffer.zip​ (3.5 KB ) - added by dustin@… 14 years ago.
Updated version of trivial patch

Download all attachments as: .zip

Change History (6)

by dustin@…, 14 years ago

Attachment: circular_buffer.tar.gz​ added

trivial patch for shadow errors

comment:1 by Jan Gaspar, 14 years ago

I don't like the the parameter name 'capacity_sz'. It reminds me the hungarian notation. Can be this changed to 'buffer_capacity'?

by dustin@…, 14 years ago

Attachment: circular_buffer.zip​ added

Updated version of trivial patch

comment:2 by dustin@…, 14 years ago

That sounds good to me.

comment:4 by Dustin Spicuzza <dustin@…>, 13 years ago

Jano,

I see this didn't get included in 1.39. Any chance it will make it in 1.40? I changed the variables as you asked. :)

comment:5 by Jan Gaspar, 13 years ago

Milestone: Boost 1.39.0 → Boost 1.40.0
Resolution: → fixed
Status: new → closed

applied to trunk ... will be applied to release branch as soon as trunk passes unit tests

Note: See TracTickets for help on using tickets.