boost::random::detail::uniform_int_float constructor

[rick68@…]

Hi,

In <boost/random/detail/uniform_int_float.hpp>

line32: uniform_int_float(base_type rng, IntType min_arg = 0, IntType max_arg = 0xffffffff)
line33: : _rng(rng), _min(min_arg), _max(max_arg)
line34: {
line35: init();
line36: }

line68: void init()
line69: {
line70: _range = static_cast<base_result>(_max-_min)+1;
line71: }

If IntType is "unsigned long" and "min_arg = 0", "max_arg = 0xffffffff"; after call constructor, _range will be zero. Becouse "0 + 0xffffffff + 1" is 0, so when we call operator() anytime, it always return 0. Is it normal?

[Steven Watanabe]

No. This is not supposed to happen. How did you run into this problem? uniform_int_float is in a detail namespace, so you shouldn't be using it directly.

[Rick Yang <rick68@…>]

Hi, Yes, I directly use it. I think I shouldn't do that. :p

[Steven Watanabe]

Also, base_result should be a floating point type, so as long as IntType is unsigned (and IntType is unsigned in all uses inside the random library) there should be no problem with overflow.