boost::uniform_01<> template parameter mistake

[rick68@…]

Hi,

In <boost/random/uniform_01.hpp> (r51337)

line183: template<class UniformRandomNumberGenerator = double, class RealType = double>

UniformRandomNumberGenerator can't use "double" to be default type.

[rick68@…]

Hi,

I confuse old "UniformRandomNumberGenerator" and your new "UniformRandomNumberGenerato". I tried in my test code.

---

#include <boost/random.hpp>

int main(void) {

boost::uniform_01<boost::mt19937> rng; return 0;

}

---

It's can't compile success.

[Steven Watanabe]

Yes. That's expected. The code shouldn't have compiled before my changes either.

#include <boost/random.hpp>

int main(void) {
    boost::uniform_01<boost::mt19937> rng; // illegal--no default constructor
    
    boost::mt19937 rng;

    // ok.  Old implementation.  Copies rng.
    boost::uniform_01<boost::mt19937> dist(rng);
    double x = dist();

    // ok.  Modification of old implementation.
    // stores a reference to rng.
    boost::uniform_01<boost::mt19937&> dist(rng);
    double x = dist();

    // ok.  new implementation
    boost::uniform_01<> dist;
    double x = dist(rng);
    
    return 0;
}