Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#3041 closed Patches (fixed)

[GIL] Patch for regression test failures in GCC 4.4

Reported by: Richard Webb <richard.webb@…> Owned by: Hailin Jin
Milestone: Boost 1.40.0 Component: gil USE GITHUB
Version: Boost Development Trunk Severity: Problem
Keywords: Cc: tim@…

Description

The GIL regression tests have a number of failures on GCC 4.4, bue to conflicts between gil::at_c and mpl::at_c.

for example:

http://tinyurl.com/qag3e3

http://tinyurl.com/qdxwna

The attached patch avoids these problems by qualifying some calls to at_c with gil::, and additionaly replaces the 'using namespace std' in pixel.cpp with 'using std::swap' in order to avoid an ambiguity with std::prev (as seen in the second link above).

Attachments (2)

gil.patch (10.7 KB ) - added by Richard Webb <richard.webb@…> 13 years ago.
patch.diff (1.6 KB ) - added by peter@… 13 years ago.
Additional fixes.

Download all attachments as: .zip

Change History (9)

by Richard Webb <richard.webb@…>, 13 years ago

Attachment: gil.patch added

comment:1 by tim@…, 13 years ago

Cc: tim@… added

comment:2 by Hailin Jin, 13 years ago

Resolution: fixed
Status: newclosed

Fixed in Revisions 54725 and 54726

by peter@…, 13 years ago

Attachment: patch.diff added

Additional fixes.

comment:3 by peter@…, 13 years ago

Resolution: fixed
Status: closedreopened

The original patch didn't fix the bug on my system; there were still compilation errors involving mpl. I modified two GIL files in a couple places to refer to gil::at_c rather than simply at_c, as the original patch had done elsewhere. With the modified files, GIL compiles on my system, and code using GIL (such as the GIL examples) works. I have not, however, applied any regression tests.

I don't know why the patch here, which presumably worked for the author, did not fix the problem on my system.

in reply to:  3 comment:4 by Richard Webb <richard.webb@…>, 13 years ago

Replying to peter@…:

I don't know why the patch here, which presumably worked for the author, did not fix the problem on my system.

The patch i posted was purely to fix failures in the regression tests (i don't use GIL myself, so i didn't do further tests).

There is also #3619 about this same issue, though in that case the existing change already seems to have fixed the reporters problems.

comment:5 by chhenning, 13 years ago

(In [58777]) Added gil:: namespace to all at_c calls. This seems necessary for current gcc ( 4.4 and more ) compilers. See #3041 and #3619.

comment:6 by chhenning@…, 13 years ago

Resolution: fixed
Status: reopenedclosed

I have tried to reproduce the problem with the current trunk ( 01/06/10 ) and release branch using MinGW 5.1.6 ( gcc 4.4 ). The problem could not be reproduced.

comment:7 by chhenning, 12 years ago

(In [65907]) Added gil:: namespace to all at_c calls. This seems necessary for current gcc ( 4.4 and more ) compilers. See #3041 and #3619.

Note: See TracTickets for help on using tickets.