Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#3137 closed Bugs (wontfix)

discover_vertex called after tree_edge in breadth_first_visit

Reported by: anonymous Owned by: Jeremiah Willcock
Milestone: Boost 1.40.0 Component: graph
Version: Boost Development Trunk Severity: Problem
Keywords: Cc:

Description

discover_vertex(target(e, g), g) should be called before tree_edge(e, g). This was the case at one point but in r8769 the order was switched. (The documentation for breadth_first_visit still reflects the original behavior.)

Calling discover_vertex before tree_edge seems to make the most sense since it provides a single place to initialize properties for vertices before they are seen as the source or target of an edge.

Change History (6)

comment:1 by Jeremiah Willcock, 13 years ago

Owner: changed from Douglas Gregor to jsiek

Let's see if Jeremy remembers the reason for this -- I changed the owner to him.

comment:2 by Jeremiah Willcock, 12 years ago

Owner: changed from jsiek to Jeremiah Willcock
Status: new → assigned

comment:3 by Jeremiah Willcock, 12 years ago

Resolution: → fixed
Status: assigned → closed

(In [62693]) Swapped order of visitor calls; fixes #3137

comment:4 by Jeremiah Willcock, 12 years ago

Resolution: fixed
Status: closed → reopened

Swapping back -- tests assume previous order.

comment:5 by Jeremiah Willcock, 12 years ago

Resolution: → wontfix
Status: reopened → closed

comment:6 by Jeremiah Willcock, 12 years ago

(In [62998]) Reverted r62693 (order of discover_vertex and examine_edge); refs #3137

Note: See TracTickets for help on using tickets.