Boost::Accumulators::Statistics: Unused Variables and Globals Cause Warnings/Errors When Headers Are Not in System Path

[gerickson@…]

I've recently added Boost 1.39.0 to an Xcode 3.1.3 project with the following warnings enabled in GCC/G++ 4.0.1:

-Werror -Wreturn-type -Wunused-function -Wunused-label -Wunused-variable -Wshadow

Unfortunately, when boost is not installed in a "system" path--as is the case here--unused and shadow variable warnings cause the build to fail when warnings are treated as errors. This issue last came up for me about a year ago in 1_35_0 with filesystem.hpp:

​http://article.gmane.org/gmane.comp.lib.boost.user/38297/match=shadow+variables+cause

The included headers this time are:

boost/accumulators/statistics/rolling_sum.hpp

To test and fix, I isolated with:

printf "#include <${BoostHeader}>\nint main(void) { return 0; }" | /Developer/usr/bin/gcc-4.0 -x c++ -Wall -Wshadow -Werror -Wreturn-type -Wunused-function -Wunused-label -Wunused-parameter -Wunused-variable -Wunused-value -o test -I${BoostRoot}/boost/include -

The patches to address this are attached and impact the headers below:

boost/accumulators/statistics/rolling_sum.hpp

[Eric Niebler]

(In [55050]) eliminate shadow warnings and unused variable warnings, fixes #3262, fixed #3276, fixes #3031