Opened 13 years ago

Closed 13 years ago

#3505 closed Bugs (fixed)

mapped_file windows handle validity check patch against 1.40.0

Reported by: yrs90@… Owned by: Jonathan Turkanis
Milestone: Boost 1.41.0 Component: iostreams
Version: Boost 1.40.0 Severity: Problem
Keywords: Cc:

Description

Windows CreateFile returns INVALID_HANDLE_VALUE on failure while CreateFileMapping returns NULL. is_open() and cleanup_and_throw(...) assumed reversed.

Attachments (2)

mapped_file.cpp.patch​ (1.4 KB ) - added by yrs90@… 13 years ago.
mapped_file, Windows build, invalid handle check patch
mapped_file.cpp.2.patch​ (1015 bytes ) - added by yrs90@… 13 years ago.
mapped_file, Windows build, invalid handle check patch (omits diff against unrelated file mistakenly included in previous patch)

Download all attachments as: .zip

Change History (4)

by yrs90@…, 13 years ago

Attachment: mapped_file.cpp.patch​ added

mapped_file, Windows build, invalid handle check patch

by yrs90@…, 13 years ago

Attachment: mapped_file.cpp.2.patch​ added

mapped_file, Windows build, invalid handle check patch (omits diff against unrelated file mistakenly included in previous patch)

comment:1 by Daniel James, 13 years ago

(In [57612]) Fix mapped file errors in windows. Refs #3505.

By Richard Smith.

comment:2 by Daniel James, 13 years ago

Resolution: → fixed
Status: new → closed

(In [58633]) Merge iostream fixes, mostly by Richard Smith.

Fixes #3612, #3311, #2094, #3010, #2894, #3011, #3352, #3505.

Note: See TracTickets for help on using tickets.