#3833 closed Patches (fixed)
boost python calling conventions support patch submission (__stdcall, __cdecl, __fastcall)
| Reported by: | Owned by: | Dave Abrahams | |
|---|---|---|---|
| Milestone: | Boost 1.42.0 | Component: | python USE GITHUB |
| Version: | Boost Development Trunk | Severity: | Problem |
| Keywords: | boost python patch calling convention | Cc: |
Description
I once more got my hands into my patch for adding support of various calling conventions to boost.python.
I tried to include the comments that were made a long time ago, and took an approach close to the one used in boost.bind : the defaut is to not support any additional calling conventions. Preprocessor defines allow to enable them : BOOST_PYTHON_ENABLE_CDECL, BOOST_PYTHON_ENABLE_STDCALL, BOOST_PYTHON_ENABLE_FASTCALL.
I added entries to documentation, and simple unit tests inspired by boost.bind once again.
The new tests should probably not be run on compilers where the calling conventions are irrelevant, but this exceeds both my bjam and compiler specifics knowledge.
The patch attached is made against the current trunk (rev.58712), on my MSCV8 SP1 every boost.python test passes.
What more work should be done to get it accepted into trunk / 1.42 release ?
Attachments (1)
Change History (5)
by , 13 years ago
| Attachment: | boost_python_calling_conventions.patch added |
|---|
comment:1 by , 13 years ago
| Status: | new → assigned |
|---|
This looks terrific! I'll try to get it applied ASAP. Please poke me if you don't see it in trunk by the end of the week.
comment:2 by , 13 years ago
Hi Dave, I didn't see any change in boost.python trunk - so I poke you :)
comment:3 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
patch file (svn diff)