Opened 13 years ago

Closed 12 years ago

#3862 closed Patches (fixed)

future.hpp - conversion from size_t to unsigned int

Reported by: dauphic@… Owned by: Anthony Williams
Milestone: Boost 1.43.0 Component: thread
Version: Boost 1.41.0 Severity: Problem
Keywords: Cc: nigels@…

Description

Lines 411, 413, 426 of future.hpp emit a warning (conversion from size_t to unsigned int) on Visual Studio 2005. I changed the lines to use std::vector<registered_waiter>::size_type instead, in the attached file.

Attachments (2)

futures-patch.hpp​ (37.9 KB ) - added by dauphic@… 13 years ago.
Patched futures.hpp
boost_future_count.diff​ (430 bytes ) - added by nigels@… 13 years ago.
unsigned -> count in line "426"

Download all attachments as: .zip

Change History (5)

by dauphic@…, 13 years ago

Attachment: futures-patch.hpp​ added

Patched futures.hpp

comment:1 by Steven Watanabe, 13 years ago

Do you think you could attach a unified diff instead of the whole file? It's a little hard to see exactly what you changed.

by nigels@…, 13 years ago

Attachment: boost_future_count.diff​ added

unsigned -> count in line "426"

comment:2 by nigels@…, 13 years ago

Cc: nigels@… added
Milestone: Boost 1.42.0 → Boost 1.43.0

Judging by the line numbers and the description, there only remains one line to change. (See the attachment) It's entirely consistent with all_futures_lock::all_futures_lockto use count_type to iterate.

This ought to be a trivial change to resolve for 1.43.0

comment:3 by Anthony Williams, 12 years ago

Resolution: → fixed
Status: new → closed

Fixed on trunk

Note: See TracTickets for help on using tickets.