bimap build fails without serialization library

[jdsiiro@…]

Builds including Bimap fail unless the Serialization library is present (even when defining BOOST_BIMAP_DISABLE_SERIALIZATION). This is caused by a reference to a missing header file (boost/serialization/nvp.hpp). A fix appears to be to guard those #includes within #ifndefs:

detail/set_view_iterator.hpp

@@ -19 +19 @@
 #include <boost/config.hpp>
 
 // Boost
-#include <boost/serialization/nvp.hpp>
+#ifndef BOOST_BIMAP_DISABLE_SERIALIZATION
+    #include <boost/serialization/nvp.hpp>
+#endif
 #include <boost/iterator/detail/enable_if.hpp>
 #include <boost/iterator/iterator_adaptor.hpp>
 #include <boost/bimap/relation/support/get_pair_functor.hpp>

detail/map_view_iterator.hpp

@@ -19 +19 @@
 #include <boost/config.hpp>
 
 // Boost
-#include <boost/serialization/nvp.hpp>
+#ifndef BOOST_BIMAP_DISABLE_SERIALIZATION
+    #include <boost/serialization/nvp.hpp>
+#endif
 #include <boost/iterator/detail/enable_if.hpp>
 #include <boost/iterator/iterator_adaptor.hpp>
 #include <boost/bimap/relation/support/pair_by.hpp>

relation/mutant_relation.hpp

@@ -21 +21 @@
 #include <boost/mpl/vector.hpp>
 #include <boost/operators.hpp>
 #include <boost/call_traits.hpp>
-#include <boost/serialization/nvp.hpp>
+#ifndef BOOST_BIMAP_DISABLE_SERIALIZATION
+    #include <boost/serialization/nvp.hpp>
+#endif
 
 #include <boost/functional/hash/hash.hpp>

In addition, this exposes a missing dependence on boost/throw_exception.hpp that can be resolved (albeit, non-ideally) through the following:

bimap.hpp

@@ -55 +55 @@
 
 #ifndef BOOST_BIMAP_DISABLE_SERIALIZATION
     #include <boost/serialization/nvp.hpp>
+#else
+    #include <boost/throw_exception.hpp>
 #endif // BOOST_BIMAP_DISABLE_SERIALIZATION
 
 // Boost.Bimap

[Matias Capeletto]

(In [78154]) [Bimap] Remove spurious dependency on Boost.Serialization (Fix #3868)

[Matias Capeletto]

(In [78573]) [Bimap] Merge to release ( [78154] Fix #3868, [78159] Fix #5749 )