Opened 13 years ago
Closed 7 years ago
#3897 closed Bugs (fixed)
Test framework does not include <osreldate.h> before testing __FreeBSD_version
| Reported by: | Owned by: | Gennadiy Rozental | |
|---|---|---|---|
| Milestone: | Boost 1.60.0 | Component: | test |
| Version: | Boost 1.42.0 | Severity: | Problem |
| Keywords: | test freebsd osreldate version | Cc: |
Description
The file boost/test/impl/execution_monitor.ipp tests FreeBSD_version without including <osreldate.h> first. This causes compilation warnings about preprocessor symbol redefinitions.
Patch to fix the problem:
diff -dur boost_1_42_0.orig/boost/test/impl/execution_monitor.ipp boost_1_42_0/boost/test/impl/execution_monitor.ipp --- boost_1_42_0.orig/boost/test/impl/execution_monitor.ipp 2009-11-28 20:19:18.000000000 +1100 +++ boost_1_42_0/boost/test/impl/execution_monitor.ipp 2010-02-04 21:23:20.301652051 +1100 @@ -155,6 +155,7 @@
# include <setjmp.h>
# if defined(FreeBSD)
+# include <osreldate.h>
# ifndef SIGPOLL # define SIGPOLL SIGIO
Change History (5)
comment:1 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 by , 9 years ago
Can somebody please merge this into the branches? It's not in as of 1.54-Beta1 that I can see, and it causes Boost to fail to build on non-x86 FreeBSD.
comment:3 by , 9 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:5 by , 7 years ago
| Milestone: | Boost 1.43.0 → Boost 1.60.0 |
|---|---|
| Resolution: | → fixed |
| Status: | reopened → closed |
Milestone set to 1.60, but fix appeared in 1.59.
(In [62780]) #include <osreldate.h> on FreeBSD. Fixes #3897