Warnings in Boost 1.42

[Stefan Roiser <stefan.roiser@…>]

Hi,

compiling Boost 1.42 e.g. on gcc 4.3.2 produces the following warnings (-Wall)

/include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_gmtoff' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_hour' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_isdst' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_mday' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_min' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_mon' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_sec' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_wday' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_yday' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_year' /include/boost-1_42/boost/date_time/gregorian/conversion.hpp:44: warning: missing initializer for member 'tm::tm_zone' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_gmtoff' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_hour' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_isdst' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_mday' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_min' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_mon' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_sec' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_wday' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_yday' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_year' /include/boost-1_42/boost/date_time/posix_time/conversion.hpp:46: warning: missing initializer for member 'tm::tm_zone' /include/boost-1_42/boost/iterator/iterator_facade.hpp:652: warning: type qualifiers ignored on function return type /include/boost-1_42/boost/lambda/detail/lambda_functors.hpp:164: warning: type qualifiers ignored on function return type /include/boost-1_42/boost/lambda/detail/select_functions.hpp:55: warning: type qualifiers ignored on function return type /include/boost-1_42/boost/lambda/detail/select_functions.hpp:60: warning: type qualifiers ignored on function return type /include/boost-1_42/boost/lambda/detail/select_functions.hpp:65: warning: type qualifiers ignored on function return type /include/boost-1_42/boost/spirit.hpp:18:4: warning: #warning "This header is deprecated. Please use: boost/spirit/include/classic.hpp" /include/boost-1_42/boost/spirit.hpp:18:4: warning: #warning is a GCC extension /include/boost-1_42/boost/spirit/home/classic/phoenix/actor.hpp:343: warning: type qualifiers ignored on function return type /include/boost-1_42/boost/spirit/phoenix.hpp:18:4: warning: #warning "This header is deprecated. Please use: boost/spirit/include/phoenix1.hpp" /include/boost-1_42/boost/spirit/phoenix.hpp:18:4: warning: #warning is a GCC extension

Could you please have a look into fixing those.

Thanks

Stefan

[Steven Watanabe]

I'm not certain that the date_time warnings are fixable. The code is correct, since the empty braces are specified to zero initialize all members. The alternative is value initialization, and some older compilers have trouble with that. Also, from the man pages, it appears that they come from -Wextra rather than -Wall.

[Steven Watanabe]

It's hard to tell what's up with the lambda warnings without having a test case. All of the lambda tests pass with -Wall -Wextra -pedantic -Werror on gcc 4.4.1. The spirit warnings are intentional.

[Marshall Clow]

Closing. See comment above by Steven W. as to why we're not fixing this.

[Marshall Clow]

See also ticket #3477