GCC warnings in normal_distribution.hpp

[bluescarni@…]

GCC 4.4.3 with '-Wall -Wextra' compilation flags produce the following warning when compiling code using normal_distribution.hpp:

warning: ‘delta.boost::variate_generator<boost::lagged_fibonacci607&, boost::normal_distribution<double> >::_dist.boost::normal_distribution<double>::_r1’ may be used uninitialized in this function

Indeed, both constructor of normal_distribution.hpp do not initialise the _r1, _r2 and _cached_rho members. It seems to me this has no consequences, because the logic of operator() initialises them as needed, but probably GCC is unable to detect this.

The proposed patch (against 1.42.0) initialises to zero the _r1, _r2 and _cached_rho data members in both constructors.

[bluescarni@…]

Proposed patch to initialise to zero the _r1, _r2 and _cached_rho data members of normal_distribution.hpp

[Steven Watanabe]

As a matter of fact, the stream operators can use _r1 and _cached_rho before they are initialized, so this is a real problem.

[Steven Watanabe]

(In [62545]) Make sure that all members are initialized. Fixes #4085