Opened 12 years ago

Closed 12 years ago

#4385 closed Patches (fixed)

Avoid redefining BOOST_NO_TYPEID and BOOST_NO_RTTI for gcc 4.3+

Reported by: nigels.com@… Owned by: John Maddock
Milestone: Boost 1.44.0 Component: config
Version: Boost 1.43.0 Severity: Cosmetic
Keywords: gcc BOOST_NO_TYPEID BOOST_NO_RTTI NaCl Cc:

Description

Our codebase is configured to use BOOST_NO_TYPEID and BOOST_NO_RTTI for various compiler toolchains. When we use gcc 4.4 as bundled in the Google Native Client (NaCl) SDK for OSX and Linux, we see compilation warnings due to the autodetection as follows: 

//
// RTTI and typeinfo detection is possible post gcc-4.3:
//
#if __GNUC__ * 100 + __GNUC_MINOR__ >= 403
#  ifndef __GXX_RTTI
#     define BOOST_NO_TYPEID
#     define BOOST_NO_RTTI
#  endif
#endif

Our proposed patch is to avoid redefining either of these: 

//
// RTTI and typeinfo detection is possible post gcc-4.3:
//
#if __GNUC__ * 100 + __GNUC_MINOR__ >= 403
#  ifndef __GXX_RTTI
#    ifndef BOOST_NO_TYPEID
#      define BOOST_NO_TYPEID
#    endif
#    ifndef BOOST_NO_RTTI
#      define BOOST_NO_RTTI
#    endif
#  endif
#endif

Attachments (1)

boost_gcc_redefines.diff​ (496 bytes ) - added by nigels.com@… 12 years ago.
Patch for boost w.r.t revision 63409

Download all attachments as: .zip

Change History (3)

by nigels.com@…, 12 years ago

Attachment: boost_gcc_redefines.diff​ added

Patch for boost w.r.t revision 63409

comment:1 by Steven Watanabe, 12 years ago

Component: build → config
Owner: changed from Vladimir Prus to John Maddock

comment:2 by John Maddock, 12 years ago

Resolution: → fixed
Status: new → closed

(In [63439]) Patch for macro redefinitions. Fixes #4385.

Note: See TracTickets for help on using tickets.