is_iequal optimization

[olafvdspek@…]

Wouldn't return Arg1 == Arg2

std::toupper<T1>(Arg1,m_Loc)==std::toupper<T2>(Arg2,m_Loc);

be faster, since it might avoid the toupper calls?

            template< typename T1, typename T2 >
                bool operator()( const T1& Arg1, const T2& Arg2 ) const
            {
                #if defined(__BORLANDC__) && (__BORLANDC__ >= 0x560) && (__BORLANDC__ <= 0x564) && !defined(_USE_OLD_RW_STL)
                    return std::toupper(Arg1)==std::toupper(Arg2);
                #else
                    return std::toupper<T1>(Arg1,m_Loc)==std::toupper<T2>(Arg2,m_Loc);
                #endif
            }

[anonymous]

Argh, I hate Trac!

return Arg1 == Arg2 || std::toupper<T1>(Arg1,m_Loc)==std::toupper<T2>(Arg2,m_Loc); 

[anonymous]

Hi,

Can you provide some simple measures, that will support your proof? The idea seems valid, but I would like to see the facts.

Pavol.

[olafvdspek@…]

Benchmarks are either simple or good, but not both. ;)

I could try to generate some numbers if you really wish.

[anonymous]

Pavol?

[Pavol Droba]

The change's not there yet. Have you done some testing?

[Marshall Clow]

Olaf - do you have any numbers to show that this will be a speed up?

Thanks, Marshall

[Olaf van der Spek <olafvdspek@…>]

Nope. Let's just drop the idea. If the arguments aren't equal, the change won't help at all.