Opened 12 years ago

Closed 12 years ago

#4537 closed Patches (invalid)

suggestion to remove warning of comparison about singned and unsigned

Reported by: Philipp Huber <phu@…> Owned by: Aleksey Gurtovoy
Milestone: Boost 1.44.0 Component: mpl
Version: Boost 1.43.0 Severity: Cosmetic
Keywords: warning signed unsigned Cc:

Description

I haven't got into mpl to actually understand, what the lines are doing I suggest to correct, they actually don't make sense to me. However, they are causing a long template warning in the context of using boost::text_archive about comparing unsigned with signed which causes eclipse to interpret it as an error for unknown reasons.

so I suggest the following patch (the revision numbers are those of my own repository):

Index: boost/mpl/print.hpp =================================================================== --- print.hpp (revision 1772) +++ print.hpp (revision 1773) @@ -57,7 +57,7 @@

# if defined(EDG_VERSION)

aux::dependent_unsigned<T>::value > -1

# else

  • sizeof(T) > -1

+ sizeof(T) >= 0

# endif

};

#endif

Change History (2)

comment:1 by Philipp Huber <phu@…>, 12 years ago

Keywords: warning signed unsigned added

comment:2 by Steven Watanabe, 12 years ago

Resolution: invalid
Status: newclosed

This warning is intentional. mpl::print is supposed to generate a warning. See http://www.boost.org/doc/libs/1_40_0/libs/serialization/doc/rationale.html#trap. Note that this was downgraded to a warning. For some reason the rationale was removed from the documentation.

Note: See TracTickets for help on using tickets.