Range Adaptor: enumerate(d)

[Ilya Murav'jov <muravev@…>]

I use B.Range with B.Foreach closely and consider boost::adaptors::indexed() not so good one. I would like to use it as follows:

std::vector<T> array;
BOOST_FOREACH( boost::index_value<T&> iv, array | enumerated() )
{
   int i = iv.index();
   T&  t = iv.value();
   ...
}

I've implemented such one in my program (using indexed() as source), ​http://gitorious.org/bombono-dvd/bombono-dvd/blobs/master/src/mlib/range/enumerate.h and hope it will be useful for others too.

[Ilya Murav'jov <muravev@…>]

enumerate.h

[Neil Groves]

I just wanted to update the ticket to explain that I am having issues when applying this patch as it was supplied with a variety of compilers and platforms. I'm going to investigate this further and produce a solution. It is however taking a lot longer than I would expect a simple patch application to take since it requires some development work and obviously documentation.

I am having to reconsider my previous work. I am honestly wrestling with the idea that perhaps I should deprecate the old interface. I am also considering if this should be implemented in terms of other new work.

I apologise for the delay. For the early delay this was simply due to me not having time to dedicate to Boost. This further delay, while other tickets have been addressed, is due to the issues outlined above.

[Neil Groves]

I have got an implementation of the enumerated adaptor implemented and working on many compilers and platforms with a similar interface to the one suggested by Ilya.

I believe that having indexed and enumerated would create significant confusion. The indexed adaptor has not been taken up much since my design decision to put the index into the iterator was almost useless. I am therefore intending to rename my enumerated implementation to indexed and replace it. This is a very rare breaking change to Boost.Range, but one that will not affect many people due to the horrendous usability of my first design.

[Neil Groves]

The new indexed adaptor is committed to the develop branch. Once the regression tests successfully cycle I shall promote to the master branch.

[Ilya Murav'jov]

Thanks, I'll see it.

[Neil Groves]

This is working fine on develop. The new version is merged to master to be released in 1.56.

Sorry for the length of time I required to get this done. This is definitely one of my poorer efforts maintaining Boost.Range. I believe I have learned to avoid some of my mistakes with this.

[Ilya Murav'jov]

Ah, don't worry!