real test expected failure should be marked as such

[Jim Bell <jim@…>]

The qi/real.cpp test failure is described as expected in source-code comments, and indeed fails on every platform.

..\libs\spirit\test\qi\real.cpp(421): test 'test_attr("123233.4124", float_, f) && f == 123233.4140625f' failed in function 'int main()'
1 error detected.

This failure reduces the value of the other tests in qi/real that do pass, as the whole test is marked failed.

Further, this failure causes the entire spirit library to be marked as fail/yellow across every platform.

I suggest splitting the expected failure into a separate test and marking it as an expected failure (see the regression test legend at the bottom of the page). This would better reflect the state of both qi/real and the entire spirit library.

Also, shouldn't the local compare() function be used here instead of operator==()?

[viboes]

I don't see this as a showstopper. Please could you set it as a Problem?

[Jim Bell <jim@…>]

Not a showstopper, but I'd like like the next release pass as many tests as possible.

[Hartmut Kaiser]

I rolled back the offending test on the release branch for now. This removes the yellow boxes there. We'll attend to that problem before the next release.

[Joel de Guzman]

broken invalid test was removed