Opened 12 years ago
Closed 12 years ago
#4905 closed Patches (fixed)
Implementation of boost::range::map_keys should use boost::range_reference
| Reported by: | Owned by: | Neil Groves | |
|---|---|---|---|
| Milestone: | Boost 1.46.0 | Component: | range |
| Version: | Boost 1.45.0 | Severity: | Optimization |
| Keywords: | Cc: |
Description
The following thread provides detailed background for the problem: http://thread.gmane.org/gmane.comp.lib.boost.devel/211127
This patch simply replaces the usage of boost::range_value<Range>::type& with boost::range_reference<Range>::type in the implementation of select_first, select_second_mutable and select_second_const functors from boost::range_detail namespace. I did not run the regression tests, but I believe there's nothing to get broken here.
Attachments (1)
Change History (3)
by , 12 years ago
| Attachment: | range.diff added |
|---|
comment:1 by , 12 years ago
| Status: | new → assigned |
|---|
Thankyou very much for this excellent defect report. I shall perform some additional testing with chained adaptors, since the introduction of references can lead to sneaky regressions with temporary values.
I really appreciate your help.
comment:2 by , 12 years ago
| Milestone: | To Be Determined → Boost 1.46.0 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Resolved on the trunk. Passing regression tests.
patch