Opened 12 years ago

Closed 12 years ago

#4918 closed Patches (fixed)

concept_check.hpp triggers self-assignment warnings

Reported by: gromer@… Owned by: Marshall Clow
Milestone: To Be Determined Component: concept_check
Version: Boost 1.45.0 Severity: Problem
Keywords: Cc:

Description

boost/concept_check.hpp contains two instances of assigning a variable to itself. In context, this is perfectly safe (since the code should never actually be executed), but it nonetheless triggers gcc's -Wself-assign, cluttering the build output for those who have that flag set, and breaking the build for those who also set -Werror. So far as I can tell, this code can be trivially rewritten to avoid the warning without any correctness or performance impact (see the attached patch).

Attachments (1)

selfassign.patch​ (1.8 KB ) - added by gromer@… 12 years ago.
Patch to fix bug

Download all attachments as: .zip

Change History (5)

by gromer@…, 12 years ago

Attachment: selfassign.patch​ added

Patch to fix bug

comment:1 by Vicente Botet <vicente.botet@…>, 12 years ago

Type: Bugs → Patches

comment:2 by Marshall Clow, 12 years ago

(In [67742]) Applied patch - refs #4918; will merge to release after tests cycle

comment:3 by Marshall Clow, 12 years ago

Owner: changed from jsiek to Marshall Clow

comment:4 by Marshall Clow, 12 years ago

Resolution: → fixed
Status: new → closed

(In [67792]) Merging fixes to release; fixes #2294 fixes #4918 fixes #3645 refs #2823 refs #1427 refs #2893

Note: See TracTickets for help on using tickets.