Opened 12 years ago

Closed 12 years ago

#5055 closed Bugs (fixed)

Quickbook (Trunk) Windows Compile Errors

Reported by: raptorfactor@… Owned by: Daniel James
Milestone: Boost 1.46.0 Component: quickbook
Version: Boost Development Trunk Severity: Regression
Keywords: quickbook filesystem Cc:

Description

Under Windows, the default character type for file paths is wchar_t. The Quickbook code assumes that it's char, and as such, compile errors are caused by the use of boost::filesystem::path::native. Quickbook should instead be using boost::filesystem::path::string, which is the same as 'native', in that it still returns a native path, it just always returns it as a narrow string.

Technically this is a bandaid fix, and Quickbook should be updated to support wide paths so they can be used under Windows (as it's the only way to support certain locales correctly), but that's a totally different issue.

At least with this patch it should now compile.

Attachments (1)

quickbook_windows_compile.patch (2.7 KB ) - added by Joshua Boyce <raptorfactor@…> 12 years ago.

Download all attachments as: .zip

Change History (5)

by Joshua Boyce <raptorfactor@…>, 12 years ago

comment:1 by Joshua Boyce <raptorfactor@…>, 12 years ago

Milestone: To Be DeterminedBoost 1.46.0
Type: PatchesBugs

comment:2 by Daniel James, 12 years ago

(In [67908]) Fix quickbook windows compile error. Refs #5055.

Patch by Joshua Boyce. Thanks.

comment:3 by Daniel James, 12 years ago

Owner: changed from Joel de Guzman to Daniel James
Status: newassigned

I've created a new ticket #5056 for supporting wide paths.

comment:4 by Daniel James, 12 years ago

Resolution: fixed
Status: assignedclosed

(In [68115]) Merge quickbook from trunk.

  • Use a single symbol table for all elements.
  • Fix filesystem use on windows. Fixes #5055.
Note: See TracTickets for help on using tickets.