Opened 12 years ago

Closed 12 years ago

#5275 closed Patches (fixed)

result_of clash in interprocess tests

Reported by: Chris Jefferson Owned by: Joel de Guzman
Milestone: To Be Determined Component: fusion
Version: Boost 1.45.0 Severity: Problem
Keywords: Cc:

Description

Lots of interprocess tests have:

using namespace boost; using namespace std;

and then use result_of. This causes clashes for libraries (such as libc++) which are starting to add support for std::result_of.

I can see two obvious fixes:

1) Remove the 'using namespace std;'. They don't actually seem to be doing anything.

2) Qualify result_of with boost::

I assume (1) is the obvious fix. Except I wondered if the 'using namespace std' in most tests was there for some reason?

Attachments (2)

fusion-std.patch (9.4 KB ) - added by Chris Jefferson 12 years ago.
Removes 'using namespace std' from conflicting tests. Adds 'std::' to count and endl in the one test which did not have them.
fusion-std2.patch (9.8 KB ) - added by Chris Jefferson 12 years ago.
Updated patch

Download all attachments as: .zip

Change History (7)

by Chris Jefferson, 12 years ago

Attachment: fusion-std.patch added

Removes 'using namespace std' from conflicting tests. Adds 'std::' to count and endl in the one test which did not have them.

comment:1 by Steven Watanabe, 12 years ago

Component: Noneinterprocess
Owner: set to Ion Gaztañaga

by Chris Jefferson, 12 years ago

Attachment: fusion-std2.patch added

Updated patch

comment:2 by Chris Jefferson, 12 years ago

Added a new patch, that fixes the existing issues, and one new one, by adding a boost::fusion:: to a couple of result_of calls, in a test.

comment:3 by Ion Gaztañaga, 12 years ago

Component: interprocessfusion
Owner: changed from Ion Gaztañaga to danmarsden

using namespace std was removed from interprocess but those patches are for boost::fusion so I guess we need to change the bug owner.

comment:4 by Ion Gaztañaga, 12 years ago

Owner: changed from danmarsden to Joel de Guzman

comment:5 by Joel de Guzman, 12 years ago

Resolution: fixed
Status: newclosed

patch applied. I'll commit as soon as all the tests pass. i'm closing this one.

Note: See TracTickets for help on using tickets.