boost filesystem on Qnx trouble

[wim@…]

I had two problems with boost.filesystem in boost 1.46.1 that are addressed with the following patch:

1. Compilation failure due to missing declaration of ::rename, which is resolved by including stdio.h. See also ticket:5277

2. Runtime crash (segmentation fault) of boost::filesystem::file_size(...) because struct stat is 60 bytes in operations.cpp whereas everywhere else it is 72 bytes.

This patch fixes both issues (but probably needs to be guarded by proper preprocessor conditionals?)

diff -ru boost_1_46_1/libs/filesystem/v3/src/operations.cpp ../boost_1_46_1/libs/filesystem/v3/src/operations.cpp
--- boost_1_46_1/libs/filesystem/v3/src/operations.cpp	2011-03-03 18:00:21.000000000 +0000
+++ ../boost_1_46_1/libs/filesystem/v3/src/operations.cpp	2011-03-22 15:40:32.000000000 +0000
@@ -32,7 +32,7 @@
 
 #if !(defined(__HP_aCC) && defined(_ILP32) && \
       !defined(_STATVFS_ACPP_PROBLEMS_FIXED))
-#define _FILE_OFFSET_BITS 64 // at worst, these defines may have no effect,
+//#define _FILE_OFFSET_BITS 64 // at worst, these defines may have no effect,
 #endif
 #if !defined(__PGI)
 #define __USE_FILE_OFFSET64 // but that is harmless on Windows and on POSIX
@@ -182,6 +182,7 @@
 #include <string>
 #include <cstring>
 #include <cstdio>      // for remove, rename
+#include <stdio.h>
 #include <cerrno>
 #include <cassert>
 // #include <iostream>    // for debugging only; comment out when not in use

[Beman Dawes]

(In [71131]) Fix #5355 QNX workarounds

[Niklas Angare <li51ckf02@…>]

I've attached a proper fix to issue 2 that enables large file support. The problem was that the *FILE_OFFSET* defines were defined after some system header files were included indirectly by boost/config.hpp. I've simply moved the code block to the top and removed "!defined(__QNXNTO__) &&".

All regression tests on the release branch pass with the patch applied and a small test program is able to correctly report the size of a file that is larger than 4 gigs.

[Beman Dawes]

(In [72278]) Fix #5355, QNX large file issues. Thanks to Niklas Angare for investigating, patch, and testing.

[Niklas Angare <li51ckf02@…>]

Thanks! Any chance of this making it into 1.47? As you may have noticed trunk tests passed on QNX (runner NA-QNX650-qcc-gnu0x) after you submitted the change.