Opened 17 years ago

Closed 17 years ago

#554 closed Bugs (Rejected)

wave method visibility issue...

Reported by: uber_lexx_ Owned by: Hartmut Kaiser
Milestone: Component: None
Version: None Severity:
Keywords: Cc:

Description

in wave's cpp_context.hpp file the lines 188 and
following look something like this

#if !defined(BOOST_NO_MEMBER_TEMPLATE_FRIENDS)
protected:
/* stuff */
#endif
/* helper methods */

if i've read this correctly, if
BOOST_NO_MEMBER_TEMPLATE_FRIENDS is declared, then the
helper method's visibility is public, otherwise it is
protected. since i could find no reason why the helper
methods should be public, i think you may want to put
the protected before the #if !definded(...).

br,
alexander floh

ps: if i'm completely wrong i apologize for bothering
you ;)

Change History (1)

comment:1 by Hartmut Kaiser, 17 years ago

Status: assignedclosed
Logged In: YES 
user_id=353975

Hi Alexander,
if I put the protected keyword outside the #if/#endif, then 
the corresponding functions won't be accessible from the 
pp_iterator et.al. classes anymore when 
BOOST_NO_MEMBER_TEMPLATE_FRIENDS is defined (that's the 
reason why the friend declarations were there in the first 
place).
I'ld like to leave these functions protected because they 
are not part of the library interface. But on broken 
compilers (when BOOST_NO_MEMBER_TEMPLATE_FRIENDS defined) I 
have to make them public to allow other library components 
to access them.

Hope that clarifies the issue.
Regards Hartmut

Note: See TracTickets for help on using tickets.