Opened 11 years ago
Closed 11 years ago
#5592 closed Bugs (fixed)
Use CP_ACP not CP_THREAD_ACP [windows]
Reported by: | Owned by: | Beman Dawes | |
---|---|---|---|
Milestone: | To Be Determined | Component: | filesystem |
Version: | Boost 1.46.1 | Severity: | Problem |
Keywords: | Cc: |
Description
I've seen a few posts to boost-dev stating that it is wrong to use CP_THREAD_ACP when converting between 'ANSI' and wide filesystem paths. CP_ACP should be used as well.
The issue was raised by Yechezkel Mett in http://groups.google.com/group/boost-developers-archive/browse_thread/thread/fa5da7ff49db6d70 but received no response.
Two other users also chimed in in the discussion started at http://boost.2283326.n4.nabble.com/filesystem-path-does-not-use-global-locale-s-codecvt-facet-bug-or-feature-td3333336.html.
Note:
See TracTickets
for help on using tickets.
Applied changeset 76500, reverting to CP_ACP.
I'm ambivalent about this fix in that we don't have a test case that demonstrates it is correct. My definition of "correct" is that filesystem operational functions resolve paths exactly the same way that standard library file stream constructors/open resolve paths.
If someone could submit a test case, it would be much appreciated.
--Beman