thread.cpp: race condition in thread_proxy's thread state

[noloader@…]

Using BOOST_HAS_PTHREADS to clarify the code, but all paths appear to suffer.

extern "C" {
  static void* thread_proxy(void* param)
  {
    // try
    {
      thread_param* p = static_cast<thread_param*>(param);
      boost::function0<void> threadfunc = p->m_threadfunc;
      p->started();
      threadfunc();
    }
    ...
  }

p->started() is called *before* the actual thread function. started() will change state even if an exception occurs such that the thread is not actually started:

void started()
{
  boost::mutex::scoped_lock scoped_lock(m_mutex);
  m_started = true;
  m_condition.notify_one();
}

[viboes]

notify_one doesn't throws. So the single function that could be throw after setting m_started is the unlock implied by the scoped_lock. You should admit that there are not too many situations on which can lock a mutex and immediately after we can not unlock it, isn't it. This will be catastrophic, our system will stay with a mutex locked :(

So in reality I don't think we can fall in the situation you described, or maybe I am missing something important.

[viboes]

Move so Support request until resolution clarified.

[viboes]

It seems the described situation can not be occur.

Please, reopen it if you don't agree with the resolution.