The warning stack is not maintained

[Tsukasa Kusakabe <kusakabe@…>]

Problem

When "#include" is executed for the following file, the warning stack is destroyed. The cause is to have forgotten to write "#pragma warning(pop)".

File list

• boost/spirit/home/classic/core/composite/composite.hpp
• boost/spirit/home/classic/core/composite/actions.hpp

Impact

When the VisualStudio user uses a specific header, a part of a necessary warning is not displayed.

Reproduction code

#include <boost/config.hpp>
#pragma warning(error: 4193)

//boost/spirit/home/classic/core/composite/composite.hpp
#pragma warning(pop) // => warning C4193
#include <boost/spirit/home/classic/core/composite/composite.hpp>
#pragma warning(pop) // !!! There is not warning. !!!

//boost/spirit/home/classic/core/composite/actions.hpp
#pragma warning(pop) // => warning C4193
#include <boost/spirit/home/classic/core/composite/actions.hpp>
#pragma warning(pop) // !!! There is not warning. !!!

int main() {
  return 0;
}

Patch

boost/spirit/home/classic/core/composite/actions.hpp

@@ -125 +125 @@
         ActionT actor;
     };
 
+#if BOOST_WORKAROUND(BOOST_MSVC, >= 1400)
+#pragma warning(pop)
+#endif
+
 BOOST_SPIRIT_CLASSIC_NAMESPACE_END
 
 }} // namespace BOOST_SPIRIT_CLASSIC_NS

boost/spirit/home/classic/core/composite/composite.hpp

@@ -140 +140 @@
         boost::compressed_pair<left_embed_t, right_embed_t> subj;
     };
 
+#if BOOST_WORKAROUND(BOOST_MSVC, >= 1400)
+#pragma warning(pop)
+#endif
+
 BOOST_SPIRIT_CLASSIC_NAMESPACE_END
 
 }} // namespace BOOST_SPIRIT_CLASSIC_NS

Environment

• OS: Windows 7 Professional SP1
• Compiler:

  Microsoft Visual Studio 2010
  Version 10.0.30319.1 RTMRel
  Microsoft .NET Framework
  Version 4.0.30319 RTMRel
  

Comments

Division origin #5577

[Tsukasa Kusakabe <kusakabe@…>]

"boost/spirit/home/classic/core/composite/composite.hpp" is not corrected.

[Joel de Guzman]

you mean actions.hpp, i think. ok fixed. pls. check.

[Tsukasa Kusakabe <kusakabe@…>]

All were cured. Thank you.