The warning stack is not maintained

[Tsukasa Kusakabe <kusakabe@…>]

Problem

When "#include" is executed for the following file, the warning stack is destroyed. The cause is a misuse of "#pragma warning(default: warning-number-list)".

File list

• boost/archive/xml_wiarchive.hpp

Impact

When the VisualStudio user uses a specific header, a part of a necessary warning is not displayed.

Reproduction code

#include <boost/config.hpp>
#include <boost/exception/all.hpp>
#pragma warning(error: 4193)

//boost/archive/xml_wiarchive.hpp
#pragma warning(pop) // => warning C4193
#include <boost/archive/xml_wiarchive.hpp>
#pragma warning(pop) // !!! There is not warning. !!!
#pragma warning(pop) // !!! There is not warning. !!!

int main() {
  return 0;
}

Patch

boost/archive/xml_wiarchive.hpp

@@ -126 +126 @@
 } // namespace boost
 
 #ifdef BOOST_MSVC
-#  pragma warning(push)
-#  pragma warning(disable : 4511 4512)
+#pragma warning(pop)
 #endif
 
 #include <boost/archive/detail/abi_suffix.hpp> // pops abi_suffix.hpp pragmas

Environment

• OS: Windows 7 Professional SP1
• Compiler:

  Microsoft Visual Studio 2010
  Version 10.0.30319.1 RTMRel
  Microsoft .NET Framework
  Version 4.0.30319 RTMRel
  

Comments

Division origin #5577

[Robert Ramey]

That's an easy one.

Robert Ramey