The warning stack is not maintained

[Tsukasa Kusakabe <kusakabe@…>]

Problem

When "#include" is executed for the following file, the warning stack is destroyed. The cause is to have forgotten to write "#pragma warning(pop)".

File list

• boost/archive/xml_wiarchive.hpp

Impact

When the VisualStudio user uses a specific header, a part of a necessary warning is not displayed.

Reproduction code

#include <boost/config.hpp>
#pragma warning(error: 4193)

//boost/program_options/parsers.hpp
#pragma warning(pop) // => warning C4193
#include <boost/program_options/parsers.hpp>
#pragma warning(pop) // !!! There is not warning. !!!

//boost/program_options/variables_map.hpp
#pragma warning(pop) // => warning C4193
#include <boost/program_options/variables_map.hpp>
#pragma warning(pop) // !!! There is not warning. !!!

int main() {
  return 0;
}

Patch

boost/program_options/parsers.hpp

@@ -260 +260 @@
 
 }}
 
+#if defined(BOOST_MSVC)
+#pragma warning (pop)
+#endif
+
 #undef DECL
 
 #include "boost/program_options/detail/parsers.hpp"

boost/program_options/variables_map.hpp

@@ -211 +211 @@
 
 }}
 
+#if defined(BOOST_MSVC)
+#   pragma warning (pop)
+#endif
+
 #endif

Environment

• OS: Windows 7 Professional SP1
• Compiler:

  Microsoft Visual Studio 2010
  Version 10.0.30319.1 RTMRel
  Microsoft .NET Framework
  Version 4.0.30319 RTMRel
  

Comments

Division origin #5577

[Vladimir Prus]

I've checked in the patch.