Non const & used in ptr_map::insert

[jdoliner@…]

The boost::ptr_map inserter takes a "key_type &" rather than a "const key_type &." This is annoying if you have a function that takes a const &. I've attached a patch which should fix the problem.

[jdoliner@…]

A patch which fixes the problem.

[Alex Ku <alex.s.kudinov@…>]

still exists in 1.53.0

[anonymous]

Still there is 1.62.0 and causes the most basic examples of ptr_map to fail to compile. For instance:

    boost::ptr_map<int, int> m;
    m.insert(0, new int(5));

It's literally a one word change to fix this.

[m.champlon@…]

I believe this is actually a feature, see www.boost.org/libs/ptr_container/doc/faq.html#why-does-ptr-map-t-insert-replace-take-two-arguments-the-key-and-the-pointer-instead-of-one-std-pair-and-why-is-the-key-passed-by-non-const-reference for a rationale.