Opened 11 years ago

Last modified 4 years ago

#6150 new Bugs

[units] The Euro sign is not correctly encoded (in UTF8 or ISO-8859-1) in a source file

Reported by: denis.arnaud_boost@… Owned by: Matthias Schabel
Milestone: Boost 1.49.0 Component: units
Version: Boost 1.48.0 Severity: Problem
Keywords: encoding, UTF8 Cc:

Description

An example source file contains the Euro currency symbol, but is encoded neither in UTF-8 nor in ISO-8859-x. Could you replace that wrongly encoded symbol with a standard one, e.g., UTF8 (i.e., €)?

Among other things, that issue:

  • wrongly displays in Web browser (as seen here)
  • triggers errors when performing RPM packaging

Attachments (1)

boost-1.67.0-units-fix-non-utf8-files.patch (962 bytes ) - added by Jonathan Wakely <jwakely.boost@…> 4 years ago.
Patch to fix encoding in example file.

Download all attachments as: .zip

Change History (6)

comment:1 by Denis Arnaud <denis.arnaud_boost@…>, 11 years ago

Owner: changed from Matthias Schabel to Steven Watanabe

comment:2 by Denis Arnaud <denis.arnaud_boost@…>, 11 years ago

Owner: changed from Steven Watanabe to Matthias Schabel

comment:3 by Jonathan Wakely <jwakely.boost@…>, 7 years ago

Ping. Fedora has been carrying this patch for years, could it be fixed upstream?

comment:4 by Jonathan Wakely <jwakely.boost@…>, 4 years ago

Ping - hello? Is this thing on?

Would you prefer a github pull request? (Boost.Units doesn't appear to use github for issues so I assume not).

This is the oldest patch Fedora is still using to fix Boost. The patch needs to be rebased due to changes in the example which still don't fix this issue.

Is there some reason to keep this bogus encoding instead of using the UTF-8 standard?

by Jonathan Wakely <jwakely.boost@…>, 4 years ago

Patch to fix encoding in example file.

comment:5 by Jonathan Wakely <jwakely.boost@…>, 4 years ago

I've attached a rebased patch and also submitted https://github.com/boostorg/units/pull/28

Note: See TracTickets for help on using tickets.