Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6256 closed Bugs (fixed)

Missing "return" statement in slice::get_indicies

Reported by: wainer.vandelli@… Owned by: Ralf W. Grosse-Kunstleve
Milestone: To Be Determined Component: python USE GITHUB
Version: Boost 1.48.0 Severity: Problem
Keywords: Cc:

Description

The implementation of boost::python::slice::get_indicies in 1.48.0 always returns an uninitialized boost::python::slice::range structure, in fact silently breaking the backward compatibility.

A "return" statement appears to be missing in boost/python/slice.hpp:251 

// Incorrect spelling. DO NOT USE. Only here for backward compatibility.
// Corrected 2011-06-14.
template<typename RandomAccessIterator>
slice::range<RandomAccessIterator>
get_indicies( const RandomAccessIterator& begin,
     const RandomAccessIterator& end) const
{
   get_indices(begin, end);
}

The bug is still present in the trunk: ​http://svn.boost.org/svn/boost/trunk/boost/python/slice.hpp

Change History (2)

comment:1 by anonymous, 11 years ago

Resolution: → fixed
Status: new → closed

Sorry for this oversight. Fixed now in both the trunk (r75918) and the release branch (r75919).

comment:2 by Wainer Vandelli <wainer.vandelli@…>, 11 years ago

Thanks for the quick feedback.

Note: See TracTickets for help on using tickets.