Opened 11 years ago

Closed 6 years ago

#6286 closed Patches (fixed)

Boost 1.48 broke --python-buildid

Reported by: smr@… Owned by: Vladimir Prus
Milestone: To Be Determined Component: build
Version: Boost 1.61.0 Severity: Problem
Keywords: Cc: yan12125@…

Description

This option worked up to 1.46.1; I did not try 1.47, but with 1.48 it broke. The command sequence

        ./bootstrap.sh
        ./bjam --with-python --python-buildid=qwerty

in 1.46 produces stage/lib/libboost_python-qwerty.a in 1.48 I see stage/lib/libboost_python.a

The ID was not appended.

I am attaching the patch used in Debian to correct this.

Attachments (4)

pythonid.patch (1.8 KB ) - added by smr@… 11 years ago.
root.diff (1.2 KB ) - added by Vladimir Prus 8 years ago.
Try 2 - root repo.
mpi.diff (1.2 KB ) - added by Vladimir Prus 8 years ago.
Try 2 - mpi repo
python.diff (796 bytes ) - added by Vladimir Prus 8 years ago.
Try 2 - python repo

Download all attachments as: .zip

Change History (25)

by smr@…, 11 years ago

Attachment: pythonid.patch added

comment:1 by Daryle Walker, 11 years ago

Component: NonePython
Owner: set to Ralf W. Grosse-Kunstleve

comment:2 by Ralf W. Grosse-Kunstleve, 11 years ago

Component: PythonBuilding Boost

I'm not in a position to test the chagnes in the Jamfiles. Could someone familiar with boost.build take a look at this?

comment:3 by Ralf W. Grosse-Kunstleve, 11 years ago

Owner: changed from Ralf W. Grosse-Kunstleve to Vladimir Prus

comment:4 by robertb@…, 10 years ago

This problem is also present in boost version 1.47.

in reply to:  2 comment:5 by anonymous, 10 years ago

Replying to rwgk:

I'm not in a position to test the chagnes in the Jamfiles. Could someone familiar with boost.build take a look at this?

I patched 1.47 and it worked as expected.

comment:6 by anonymous, 10 years ago

This is still broken in 1.51.0. Could someone accept the patch?

comment:7 by anonymous, 10 years ago

Type: BugsPatches

comment:8 by smr@…, 10 years ago

Still broken in 1.52.

comment:9 by anonymous, 10 years ago

Still broken in 1.53.0 beta 1

comment:10 by Ralf W. Grosse-Kunstleve, 10 years ago

:-(

Could (did) you try your luck at boost@…?

comment:11 by viboes, 10 years ago

Component: Building Boostbuild

in reply to:  10 comment:12 by rboehne@…, 10 years ago

Replying to rwgk:

:-(

Could (did) you try your luck at boost@…?

I'm not sure what this means. If you follow the documentation and add the correct settings to build for multiple versions of python, those settings are ignored when building with Unix makefiles.

comment:13 by anonymous, 9 years ago

Still broken in 1.54.0 beta 1

in reply to:  description comment:14 by anonymous, 8 years ago

Replying to smr@…:

This option worked up to 1.46.1; I did not try 1.47, but with 1.48 it broke. The command sequence

        ./bootstrap.sh
        ./bjam --with-python --python-buildid=qwerty

in 1.46 produces stage/lib/libboost_python-qwerty.a in 1.48 I see stage/lib/libboost_python.a

The ID was not appended.

I am attaching the patch used in Debian to correct this.

This is still broken in 1.55.0. Is Boost Build still being maintained?

comment:15 by Vladimir Prus, 8 years ago

That was a bait question?

it's maintained, but it seems that this patch is specific to Debian and is automatically applied by Debian build system, so it never made it to the top of the queue.

by Vladimir Prus, 8 years ago

Attachment: root.diff added

Try 2 - root repo.

by Vladimir Prus, 8 years ago

Attachment: mpi.diff added

Try 2 - mpi repo

by Vladimir Prus, 8 years ago

Attachment: python.diff added

Try 2 - python repo

comment:16 by Vladimir Prus, 8 years ago

I've attached 3 patches that I think involve less code duplication. Do they work on your side? (I am not aware of a way to produce a single patch in this new world).

comment:17 by Vladimir Prus, 8 years ago

Do these patches work for you?

comment:18 by anonymous, 8 years ago

Still broken in 1.57.

comment:19 by Vladimir Prus, 8 years ago

Could you respond to 17, if you want this fixed?

comment:20 by yan12125@…, 6 years ago

Cc: yan12125@… added
Version: Boost 1.48.0Boost 1.61.0

Problem is still in version 1.61.0. After applying root.diff, mpi.diff and python.diff, --python-buildid works fine.

Tested on Arch Linux with Arch Linux's build scripts. [1]

[1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/boost

comment:21 by Vladimir Prus, 6 years ago

Resolution: fixed
Status: newclosed

These patches were checked in to develop. Let me know if everything is fine.

Note: See TracTickets for help on using tickets.