boost::regex::begin() and boost::regex::end() always return 0

[nowahn <nowahn@…>]

Hi,

boost::basic_regex<...>::begin() and boost::basic_regex<...>::end() always return 0 (zero). This is because of the status test in the relevant functions in boost::re_detail::basic_regex_implementation<...> (in the file boost/regex/v4/basic_regex.hpp: The test is

!this->m_status ? ...

it should be

this->m_status ? ...

(without the '!'). The status is good if equal to zero, !... is good if NOT equal to zero. Note that the str() function a few lines above have a less confusing test:

if(this->m_status == 0)

The fix is trivial: remove the '!' (or use the same test as in str()), but I tested it very quickly.

I join a small source code showing the bug, the output of this program (with bug not fixed and fixed), and a patch.

[nowahn <nowahn@…>]

Source code showing the bug.

[nowahn <nowahn@…>]

Output of the test program.

[nowahn <nowahn@…>]

Patch fixing the bug.

[John Maddock]

(In [79340]) Fix begin() and end() members and add tests. Fixes #6346.

[John Maddock]

(In [79556]) Merge collected bug fixes from Trunk: Refs #589. Refs #7032. Refs #7084. Refs #6346.