Opened 11 years ago

Closed 8 years ago

#6773 closed Patches (fixed)

Add cxxabi.h detection code for clang in boost/units/detail/utility.hpp

Reported by: Michel Morin Owned by: Jürgen Hunold
Milestone: Boost 1.57.0 Component: units
Version: Boost Development Trunk Severity: Problem
Keywords: Cc:

Description

boost::units::detail::demangle does not demangle names on clang with libc++ even when cxxabi.h is available. Attached a patch to add cxxabi.h detection code for clang. This allows boost::units::detail::demangle to use abi::__cxa_demangle on clang when cxxabi.h is available.

The patch uses clang's __has_include macro to detect cxxabi.h. This macro checks the existence of a header file. For reference, here is the link to __has_include documentation: ​http://clang.llvm.org/docs/LanguageExtensions.html#has_include

Attachments (1)

units_detail_utility.patch​ (625 bytes ) - added by Michel Morin 11 years ago.
A patch for boost/units/detail/utility.hpp to add cxxabi.h detection code for clang.

Download all attachments as: .zip

Change History (4)

by Michel Morin, 11 years ago

Attachment: units_detail_utility.patch​ added

A patch for boost/units/detail/utility.hpp to add cxxabi.h detection code for clang.

comment:1 by Andrey Semashev, 8 years ago

I believe the ticket can be closed as soon as #10116 is closed. Boost.Core implementation has support for clang.

comment:2 by Jürgen Hunold, 8 years ago

Owner: changed from Steven Watanabe to Jürgen Hunold
Status: new → assigned

comment:3 by Jürgen Hunold, 8 years ago

Milestone: To Be Determined → Boost 1.57.0
Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.