Clang warnings in basic_regex_creator.hpp

[ph03@…]

Hi! I have the following warnings with

$ clang -v clang version 3.2 (trunk) Target: x86_64-pc-linux-gnu Thread model: posix:

In file included from /usr/include/boost-1_49/boost/regex.hpp:31: In file included from /usr/include/boost-1_49/boost/regex/v4/regex.hpp:70: /usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1038:34: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]

else if((state->type == syntax_element_long_set_rep))

^~

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1038:34: note: remove extraneous parentheses around the comparison to silence this warning

else if((state->type == syntax_element_long_set_rep))

~ ^~

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1038:34: note: use '=' to turn this equality comparison into an assignment

else if((state->type == syntax_element_long_set_rep))

^{~ =}

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1116:18: warning: array subscript is of type 'char' [-Wchar-subscripts]

l_map\n |= mask;

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1117:18: warning: array subscript is of type 'char' [-Wchar-subscripts]

l_map\r |= mask;

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1118:18: warning: array subscript is of type 'char' [-Wchar-subscripts]

l_map\f |= mask;

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1305:18: warning: array subscript is of type 'char' [-Wchar-subscripts]

l_map\n |= mask;

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1306:18: warning: array subscript is of type 'char' [-Wchar-subscripts]

l_map\r |= mask;

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1341:28: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]

if((p->type == syntax_element_recurse))

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1341:28: note: remove extraneous parentheses around the comparison to silence this warning

if((p->type == syntax_element_recurse))

~ ^~

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:1341:28: note: use '=' to turn this equality comparison into an assignment

if((p->type == syntax_element_recurse))

^{~ =}

---

In file included from /usr/include/boost-1_49/boost/regex.hpp:31: In file included from /usr/include/boost-1_49/boost/regex/v4/regex.hpp:70: /usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:528:13: warning: unused function 'char_less' [-Wunused-function] inline bool char_less<char>(char t1, char t2)

/usr/include/boost-1_49/boost/regex/v4/basic_regex_creator.hpp:533:13: warning: unused function 'char_less' [-Wunused-function] inline bool char_less<signed char>(signed char t1, signed char t2)

Are this boost problems or is clang to critical about this?

[John Maddock]

(In [78431]) Fix clang warnings. Fixes #6863.

[John Maddock]

(In [78480]) Fix some more GCC warnings. Fix previous warning suppression which broke tests with GCC. Refs #6863.