call of abs is ambiguous

[Niklas Angare <li51ckf02@…>]

The regression tests this_thread__sleep_for_p* and this_thread__sleep_until_p* fail to compile on QNX 6.5.0:

sleep_for_pass.cpp:38: error: call of overloaded 'abs(long int)' is ambiguous

Here's the troublesome line:

BOOST_TEST(std::abs(static_cast<long>(ns.count())) < (err+boost::chrono::milliseconds(1000)).count());

I'm thinking that it might be a compiler bug but either way it should be easy to work around.

I guess the static_cast is a work-around for the fact that C++03 doesn't have abs(long long). I'm attaching a patch with a more reliable solution, with no risk of 32-bit overflow:

BOOST_TEST(std::max(ns, -ns) < (err+boost::chrono::milliseconds(1000)));

These also work but have the overflow problem:

BOOST_TEST(std::abs(static_cast<int>(ns.count())) < (err+boost::chrono::milliseconds(1000)).count());

BOOST_TEST(std::labs(static_cast<long>(ns.count())) < (err+boost::chrono::milliseconds(1000)).count());

As a side note; one of the tests end with return boost::report_errors() while the other one doesn't. Bug?

[viboes]

Thanks for the report. Could you tell me which one is missing return boost::report_errors();

[viboes]

OH, I see it now (libs/thread/test/threads/this_thread/sleep_until/sleep_until_pass.cpp )

[viboes]

Committed in trunk at revision 78802.

[viboes]

Merged to release branch.