Opened 10 years ago

Closed 10 years ago

#6966 closed Bugs (fixed)

future boost::future_category inconsistent dll linkage

Reported by: viboes Owned by: viboes
Milestone: Boost 1.54.0 Component: thread
Version: Boost 1.49.0 Severity: Problem
Keywords: Cc:

Description

Test output:
Rev 78804 / Mon, 4 Jun 2012 03:53:09 +0000
Report Time: Tue, 5 Jun 2012 20:20:25 +0000

Compile [2012-06-05 13:32:03 UTC]: succeed

    call "%BOOST_ROOT%/TestTools/VSVars32-VC9-STLPort.bat" x86 >nul
cl /Zm800 -nologo @"D:\BoostRT\results\boost\bin.v2\libs\thread\build\msvc-9.0~stlport5.2\debug\stdlib-stlport-5.2~vc9\future.obj.rsp" 

future.cpp
..\libs\thread\src\future.cpp(51) : warning C4273: 'boost::future_category' : inconsistent dll linkage
        D:\BoostRT\boost\boost/thread/future.hpp(98) : see previous definition of 'future_category'

Change History (6)

comment:1 by viboes, 10 years ago

Owner: changed from Anthony Williams to viboes
Status: newassigned

The following patch should fix the issue

Index: future.cpp
===================================================================
--- future.cpp	(revision 78572)
+++ future.cpp	(working copy)
@@ -46,7 +46,7 @@
     }
   }
 
-  const system::error_category&
+  BOOST_THREAD_DECL const system::error_category&
   future_category()
   {
       static thread_detail::future_error_category f;

Committed revision 78823.

comment:2 by viboes, 10 years ago

Milestone: To Be DeterminedBoost 1.50.0
Resolution: fixed
Status: assignedclosed

Fixed with [78919]

comment:3 by lodos@…, 10 years ago

Milestone: Boost 1.50.0Boost 1.54.0
Resolution: fixed
Status: closedreopened

The changeset was rolled back.

comment:4 by viboes, 10 years ago

I rolled back the change in [78863] as it was introducing a regression. I would not be able to check it again until next weekend. Does the patch work for you?

Sorry I don't know MSVC well. Is this

  const system::error_category&
  BOOST_THREAD_DECL future_category() BOOST_NOEXCEPT;

different from

  BOOST_THREAD_DECL const system::error_category&
  future_category() BOOST_NOEXCEPT;

comment:5 by viboes, 10 years ago

Changeset [83908].

comment:6 by viboes, 10 years ago

Resolution: fixed
Status: reopenedclosed

(In [83938]) Thread: merge from trunk to fix #6843,#6966.

Note: See TracTickets for help on using tickets.