Opened 10 years ago

Closed 9 years ago

#7043 closed Bugs (fixed)

A warning for compiler warning creates another compiler warning

Reported by: Hideaki Takei <hideaki.takei@…> Owned by: bronf
Milestone: To Be Determined Component: type_traits
Version: Boost 1.49.0 Severity: Cosmetic
Keywords: Cc:

Description

Please remove the unnecessary non-ascii character located just after the sceond single quotation mark at line 34 of boost/type_traits/detail/has_binary_operator.hpp. This causes a compiler warning as indicated below.

http://boost.cowic.de/rc/inspect-trunk.html#type_traits

boost\type_traits\detail\has_binary_operator.hpp:

(line 34) Non-ASCII: warning C4547: '*'Â : operator before comma has no effect; expected operator with side-effec

Following is the one I got in Visual Studio 2008 on Japanese Windows:

E:\App\boost_1_49_0\boost/type_traits/detail/has_binary_operator.hpp : warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss

The funny thing is that this comment is warning another compiler warning :)

27: // cannot include this header without getting warnings of the kind:
28: // gcc:
29: //    warning: value computed is not used
30: //    warning: comparison between signed and unsigned integer expressions
31: // msvc:
32: //    warning C4018: '<' : signed/unsigned mismatch
33: //    warning C4244: '+=' : conversion from 'double' to 'char', possible loss of data
34: //    warning C4547: '*'Â : operator before comma has no effect; expected operator with side-effect
35: //    warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance warning)

Change History (3)

comment:1 by John Maddock, 10 years ago

Owner: changed from John Maddock to bronf

comment:2 by viboes, 10 years ago

Committed in trunk [82830]. It seems to be in release branch.

comment:3 by John Maddock, 9 years ago

Resolution: fixed
Status: newclosed

Fixed in Git.

Note: See TracTickets for help on using tickets.