Opened 10 years ago

Closed 10 years ago

#7112 closed Feature Requests (fixed)

Switch case default missing in date_time

Reported by: Gaurav Gupta <g.gupta@…> Owned by: az_sw_dude
Milestone: To Be Determined Component: date_time
Version: Boost 1.51.0 Severity: Cosmetic
Keywords: Cc: yogen.saini@…

Description

In file boost/date_time/date_parsing.hpp default case of switch condition is missing at two places.Switch case should not be used without default case ideally.In case of default, code should break from the loop.

Attached patch is the fix for it.

Attachments (1)

date_parsing.2.hpp_patch​ (609 bytes ) - added by Gaurav Gupta <g.gupta@…> 10 years ago.
Fix for the reported Bug.

Download all attachments as: .zip

Change History (6)

by Gaurav Gupta <g.gupta@…>, 10 years ago

Attachment: date_parsing.2.hpp_patch​ added

Fix for the reported Bug.

comment:1 by viboes, 10 years ago

Resolution: → invalid
Severity: Problem → Cosmetic
Status: new → closed
Type: Bugs → Feature Requests

There are too much work to do to clean up Boost.DateTime. Re-open if some tool is warning a bad usage.

comment:2 by Gaurav Gupta <g.gupta@…>, 10 years ago

Similar Comment as in Ticket #7111 i.e

If our application is using "Werror" flag, then if default case is not mentioned ,it is reported as an error.

comment:3 by Gaurav Gupta <g.gupta@…>, 10 years ago

Resolution: invalid
Status: closed → reopened

comment:4 by Marshall Clow, 10 years ago

(In [80708]) Added default case labels to silence bogus warnings; Refs #7112; Refs #7113

comment:5 by Marshall Clow, 10 years ago

Resolution: → fixed
Status: reopened → closed

(In [80797]) Merge bug fixes to release; Fixes #5550 Fixes #6136 Fixes #6513 Fixes #7111 Fixes #7112 Fixes #7113 Fixes #7342 Fixes #7426

Note: See TracTickets for help on using tickets.