boost::container::basic_string::insert's implementation is inconsistent with a document

[kariya_mitsuru@…]

In boost::container::basic_string::insert, the function prototype is

  void insert(const_iterator p, size_type n, CharT c);

but the document has a return value description

Returns: An iterator which refers to the copy of the first inserted character, or p if n == 0.

Also

  template<typename InputIter> 
    void insert(const_iterator p, InputIter first, InputIter last);

and

Returns: An iterator which refers to the copy of the first inserted character, or p if first == last.

I think these functions should return an iterator written in the document, like c++11.

[Ion Gaztañaga]

Thanks for the report. In the standard these functions return void:

​http://www.cplusplus.com/reference/string/string/insert/

So documentation should be corrected.

[Ion Gaztañaga]

Fixed in trunk at revision: 80047

[Mitsuru Kariya <kariya_mitsuru@…>]

Thanks for your reply.

Until C++03 standard, these functions return void. But from C++11 standard, these functions were revised.

​http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#149

I think that basic_string (and other container in Boost.Container) would be better off returning an iterator for "C++11 Conformance".

[Ion Gaztañaga]

Thanks again, I see the change in N3776 from the pre-standard draft N3337. Reopened for future fix.

[Ion Gaztañaga]

It was fixed in Boost 1.52.