freelist_stack::allocate and freelist_stack::deallocate should not be private

[Hartmut Kaiser]

Currently, the allocate/deallocate functions et.al. in lockfree::detail::freelist_stack are private. This inhibits reusing this class for implementing other lock-free datastructures as it's not possible to allocate anything which has not a constructor taking 0, 1, or 2 arguments (those are supported explicitly by exposing overloads for freelist_stack::construct).

Would it be possible to make the mentioned functions 'protected' instead?

[timblechmann]

making allocate protected. deallocate should not be required, as one can still use the destruct method.

however in general it would be cleaner to use an api like this:

template <class... Args>
T * construct(Args&&... args)

[Hartmut Kaiser]

Replying to timblechmann:

making allocate protected. deallocate should not be required, as one can still use the destruct method.

Hmmm. In another use case I'm using freelist_stack in a special memory pool. The deallocate function is necessary for me as I'm using it from inside of a placement delete operator (the compiler has already called the destructor for me, I only need to give the memory back to the freelist). Would it be possible to leave the deallocate function protected as well, please?

however in general it would be cleaner to use an api like this:

template <class... Args>
T * construct(Args&&... args)

I agree, except for the use case above, where placement new and delete are used.