Opened 10 years ago

Closed 10 years ago

#7338 closed Bugs (fixed)

pending/indirect_cmp has wrong return type

Reported by: Alex Hagen-Zanker <ahh34@…> Owned by: Jeremiah Willcock
Milestone: To Be Determined Component: graph
Version: Boost 1.52.0 Severity: Problem
Keywords: pending Cc:

Description

The return_type for indirect_cmp now is PropertyMap::value_type it should be Compare::result_type (or simply bool).

The return type for the operator(a,b) should then be return_type instead of bool.

Also, the PropertyMap may be an LValuePropertyMap and then it might be avoided to copy the values before comparison.

Patch attached

Attachments (1)

indirect_cmp.patch (823 bytes ) - added by Alex Hagen-Zanker <ahh34@…> 10 years ago.

Download all attachments as: .zip

Change History (2)

by Alex Hagen-Zanker <ahh34@…>, 10 years ago

Attachment: indirect_cmp.patch added

comment:1 by Jeremiah Willcock, 10 years ago

Resolution: fixed
Status: newclosed

(In [80420]) Fixed issues with indirect_cmp; fixes #7338

Note: See TracTickets for help on using tickets.