Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#7455 closed Bugs (fixed)

vertex_property should inherit publicly from vertex_property_type

Reported by: sjackman@… Owned by: Jeremiah Willcock
Milestone: Boost 1.53.0 Component: graph
Version: Boost 1.51.0 Severity: Problem
Keywords: Cc:

Description

Hi,

vertex_property and edge_property should inherit publicly from vertex_property_type and edge_property_type. A patch follows.

./ContigGraph.h:55:39: error: 'type' is a private member of
      'boost::mpl::eval_if<boost::detail::has_vertex_property_type<DirectedGraph<ContigProperties,
      Distance>, mpl_::bool_<false>>,
      boost::detail::get_vertex_property_type<DirectedGraph<ContigProperties,
      Distance>>, boost::no_property>'
        typedef typename vertex_property<G>::type vertex_property_type;
                                             ^
/usr/local/include/boost/graph/properties.hpp:251:49: note: constrained by
      implicitly private inheritance here
  template <class Graph> class vertex_property: vertex_property_type<Graph> {};
                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Cheers, Shaun

--- graph/properties.hpp.orig   2012-09-27 11:37:48.000000000 -0700
+++ graph/properties.hpp        2012-10-01 10:43:34.000000000 -0700
@@ -248,8 +248,8 @@
     >::type type;
   };

-  template <class Graph> class vertex_property: vertex_property_type<Graph> {};
-  template <class Graph> class edge_property: edge_property_type<Graph> {};
+  template <class Graph> class vertex_property: public
vertex_property_type<Graph> {};
+  template <class Graph> class edge_property: public
edge_property_type<Graph> {};

   template <typename Graph>
   class degree_property_map

Change History (4)

comment:1 by sjackman@…, 10 years ago

I agree; that is fixed in r80811. Could you please file these kinds of things as bug reports so that they can be listed in the release notes, though? Thank you.

-- Jeremiah Willcock

comment:2 by Jeremiah Willcock, 10 years ago

Resolution: fixed
Status: newclosed

comment:3 by Shaun Jackman <sjackman@…>, 10 years ago

This is not fixed in Boost 1.52.0 as the milestone tag indicates. Should the milestone be changed to 1.53.0?

Cheers, Shaun

comment:4 by Jeremiah Willcock, 10 years ago

Milestone: Boost 1.52.0Boost 1.53.0
Note: See TracTickets for help on using tickets.