Opened 10 years ago

Closed 10 years ago

#7701 closed Patches (fixed)

locale is missing "std::" in some places

Reported by: tvaneerd@… Owned by: Artyom Beilis
Milestone: To Be Determined Component: locale
Version: Boost 1.52.0 Severity: Problem
Keywords: Cc:

Description

the locale library is missing "std::" in a few places (ie sometimes on time_t, sometimes on mbstate_t), and thus doesn't compile on some configurations.

fixes attached.

Attachments (2)

locale.diff​ (6.9 KB ) - added by tvaneerd@… 10 years ago.
diff of required changes
locale.diff2​ (2.2 KB ) - added by tvaneerd@… 10 years ago.
couple more I missed

Download all attachments as: .zip

Change History (8)

by tvaneerd@…, 10 years ago

Attachment: locale.diff​ added

diff of required changes

comment:1 by anonymous, 10 years ago

Summary: locale is missing "std::" in some place → locale is missing "std::" in some places

comment:2 by Artyom Beilis, 10 years ago

On what platform does the build fails?

Also mbstate_t, ptrdiff_t, time_t are part of standard C so including stuff like <time.h> or <stddef.h> should solve the problem as well.

comment:3 by anonymous, 10 years ago

Fails on QNX (and/or BlackBerry10). Yes C includes should also work. But in some places std:: was already being used on those types, so I assumed it should go in that direction.

by tvaneerd@…, 10 years ago

Attachment: locale.diff2​ added

couple more I missed

comment:4 by Artyom Beilis, 10 years ago

Status: new → assigned

comment:5 by Artyom Beilis, 10 years ago

Severity: Showstopper → Problem

comment:6 by Artyom Beilis, 10 years ago

Resolution: → fixed
Status: assigned → closed

(In [81591]) Fixed #7701 missing "std::" in some places, problem on platforms like QNX, Blackbarry

Note: See TracTickets for help on using tickets.